Remove CodeQL, add flake8 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's use something with in-code annotations instead.
"%s %s".format(1, 2) # This should have been '{} {}'
'%s %s'
awelzel
force-pushed
the
topic/awelzel/remove-codeql-add-flake8
branch
from
0696254 to
c28b6ac
Compare
Should not compare with !=.
awelzel
force-pushed
the
topic/awelzel/remove-codeql-add-flake8
branch
from
c28b6ac to
a69e9ec
Compare
Now that things are fixed up, add flake8. No fancy plugins, just base flake8 for now.
awelzel
force-pushed
the
topic/awelzel/remove-codeql-add-flake8
branch
from
a69e9ec to
77bcde4
Compare
bbannier
reviewed
Jan 17, 2023
Yeah, not sure about about having flake8 and pylint due to possibly needing to appease them with different annotations, bandit could be interesting. There's also a bunch of flake8 plugins if we wanted to go wild: https://github.com/DmytroLitvinov/awesome-flake8-extensions |
ckreibich
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ckreibich , this builds on top of your #152 but at the same time adds a flake8 pre-commit hook.
Nothing critical stands out. A bit of logging broke during #151 , otherwise minor things around unused variables, import orderings and comparisons with bool.
Prefer to add some form of linter rather than having none at all.